Improve write dashboard by removing unrelated route #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
|
Did this change work the way you expected it to @cyriltovena ? |
Yes there's other API call happening on those component that are not used for the write path. |
cstyan
approved these changes
May 31, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
What this PR does / why we need it:
Last week while on-call I realize that the latency was high in distributor but in fact it was another route (profiling) being slow. This attempts to improve the write dashboard by only including potential writes endpoint.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not sure if the jsonnet will be correct 🤷 There's might be a clash of recording rules.
Checklist
CHANGELOG.mdabout the changes.