Support limits in multi-tenant queries. #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
commented
Mar 15, 2022
simonswine
reviewed
Mar 16, 2022
jeschkies
changed the title
MaxQuerySeries and QuerySplitDuration.
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
|
I've authored some tests for limits-related util functions as well as a quick fix for I'm happy to push these commits to this PR or to PR the underlying fork; please let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes adds support for the the following limits in multi-tenant queries:
MaxQuerySeriesQuerySplitDurationMaxEntriesLimitPerQueryMinShardingLookbackMaxQueryLengthMaxQueryParallelismMaxQueriersPerUserMaxCacheFreshnessIt always uses the more restricted limit. That means the smallest
MaxQuerySeriesbut biggestQuerySplitDuration. The split duration is special. Zero means disabled.Also, the global default resolver is the multi tenant resolver when multi-tenant queries are enabled. This will result HTTP 400 errors in case the user sends multiple tenants to endpoints that do not support it.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.