logcli: Remove port from TLS server name when provided in --addr #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If connecting to a TLS secured endpoint with an explicit port, ensure that ServerName contains only the host and not the port to avoid a cert validation failure
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If connecting to a TLS secured endpoint with an explicit port with logcli, certificate validation fails:
The problem can be (insecurely) avoided by adding a
--tls-skip-verifyoption.This PR ensures that the ServerName field of the TLSConfig struct contains only the host if a port is provided to avoid
the failure.
Which issue(s) this PR fixes:
Per Contribution guide, didn't open an issue since this is a one-liner... but I can create one if needed.
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.