-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Created migration guide from SSD -> Distributed #16389
base: main
Are you sure you want to change the base?
Conversation
💻 Deploy preview available: https://deploy-preview-loki-16389-zb444pucvq-vp.a.run.app/docs/loki/latest/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice guide, thanks for putting it together!
chunk_encoding: snappy | ||
# Add this to ingester; this will force ingesters to flush before shutting down | ||
wal: | ||
flush_on_shutdown: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed after a finished migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I can leave it as optional. It depends if the operator wants to force ingesters to flush on a shutdown. I will ask Ed for his opinion aswell
Co-authored-by: Alexander Lindeskär <lindeskar@users.noreply.github.com> Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Hi, going through your doc today, the only problem I have noticed so far, is that the ruler sidecar is not migrated properly. If using a SimpleScaleable mode with a config like the following:
Then when applying the SSDM->Distributed migration, there are two problems with the new ruler pod:
|
What this PR does / why we need it:
This PR includes a migration guide from Loki SSD to Loki distributed for users using the Loki helm.
I would also like to give credit to @lindeskar for initially running through this process in the dark:
#13726
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR