-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes fluentd new push path API. #1363
Conversation
/cc @tarokkk @dawidmalina |
- also add tests for ordering. - improve nanoseconds precision. - fixes all lint/style issue. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
fbfa14a
to
3ee3309
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better 👍 Thanks for the lint work as well ;)
Although I think we need to update gem version |
No idea if I can force push, but I guess it's cleaner to bump it. |
I mean we need to bump it, you can't force push gems on the gem repo |
well I didn't know, will do ! Thanks |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
…rors Improve tracing info on DynamoDB query errors
What this PR does / why we need it:
Fixes the current 1.2.3 fluentd Loki plugin. We change the push path (#1326) but the API has actually change.
I have not bump the version as I'm planning to replace the current not working released version.
I've also:
nsec
instead ofto_f
(see . https://ruby-doc.org/core-2.6.4/Time.html#method-i-nsec)Output of rake:
Which issue(s) this PR fixes:
Fixes #1347
Special notes for your reviewer:
Checklist