Skip to content

Allow for custom querier HPA in helm chart #13276

Open

Description

Is your feature request related to a problem? Please describe.
We're switching from the loki-distributed helm chart to the loki chart and currently need to patch in a fix for the querier's replicas. We use the KEDA HPA as documented and don't want the HPA to be created. However, turning off autoscaling means we need to specify replicas which doesn't work with our gitops setup.

Describe the solution you'd like
I'd probably suggest something like customHPA which defaults to false which can be used either to effect the replicas field or, more preferable, will not create the HPA. I feel it's pedantically more correct to say "yes, I have autoscaling on" to impact the replicas field, but also saying "I will create my own."

Describe alternatives you've considered
Currently we use kustomize to fix any issues we have with helm charts so currently am running the alternative. I just figured I'd make the issue in case others aren't able to utilize an alternative.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions