Skip to content

Commit 64215e1

Browse files
authored
fix(blooms): Cleanup temp blockdir in bloom compactor (#13622)
A follow up to #13522 This PR fixes the missing cleanup function call to remove temporary blocks from the filesystem. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
1 parent 2b81a48 commit 64215e1

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

pkg/bloomcompactor/controller.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -431,6 +431,9 @@ func (s *SimpleBloomController) buildGaps(
431431
built, err := bloomshipper.BlockFrom(tenant, table.Addr(), blk)
432432
if err != nil {
433433
level.Error(logger).Log("msg", "failed to build block", "err", err)
434+
if err = blk.Reader().Cleanup(); err != nil {
435+
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
436+
}
434437
return nil, errors.Wrap(err, "failed to build block")
435438
}
436439

@@ -439,10 +442,17 @@ func (s *SimpleBloomController) buildGaps(
439442
built,
440443
); err != nil {
441444
level.Error(logger).Log("msg", "failed to write block", "err", err)
445+
if err = blk.Reader().Cleanup(); err != nil {
446+
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
447+
}
442448
return nil, errors.Wrap(err, "failed to write block")
443449
}
444450
s.metrics.blocksCreated.Inc()
445451

452+
if err := blk.Reader().Cleanup(); err != nil {
453+
level.Error(logger).Log("msg", "failed to cleanup block directory", "err", err)
454+
}
455+
446456
totalGapKeyspace := (gap.bounds.Max - gap.bounds.Min)
447457
progress := (built.Bounds.Max - gap.bounds.Min)
448458
pct := float64(progress) / float64(totalGapKeyspace) * 100

0 commit comments

Comments
 (0)