Report usages of the deprecated 'ext.loadimpact' option

Author: joanlopez

cmd/test_load.go

@@ -265,11 +265,19 @@ func loadSystemCertPool(logger logrus.FieldLogger) {
 func (lct *loadedAndConfiguredTest) buildTestRunState(
 	configToReinject lib.Options,
 ) (*lib.TestRunState, error) {
-	// This might be the full derived or just the consodlidated options
+	// This might be the full derived or just the consolidated options
 	if err := lct.initRunner.SetOptions(configToReinject); err != nil {
 		return nil, err
 	}
 
+	// Here, where we get the consolidated options, is where we check if any
+	// of the deprecated options is being used, and we report it.
+	if _, isPresent := configToReinject.External["loadimpact"]; isPresent {
+		if err := lct.preInitState.Usage.Strings("deprecated_options", "ext.loadimpact"); err != nil {
+			return nil, err
+		}
+	}
+
 	// it pre-loads system certificates to avoid doing it on the first TLS request.
 	// This is done async to avoid blocking the rest of the loading process as it will not stop if it fails.
 	go loadSystemCertPool(lct.preInitState.Logger)