From 5a9c9b946906aab40acbc3ef38e2595ac75a71ee Mon Sep 17 00:00:00 2001 From: Ankur Date: Thu, 21 Mar 2024 14:32:58 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent --- .../browser/elementhandle/setinputfiles.md | 8 ++++---- .../k6-experimental/browser/frame/setinputfiles.md | 8 ++++---- .../k6-experimental/browser/page/setinputfiles.md | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/setinputfiles.md b/docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/setinputfiles.md index 2db155bfd6..54facfe8ea 100644 --- a/docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/setinputfiles.md +++ b/docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/setinputfiles.md @@ -11,10 +11,10 @@ To work with local files on the file system, use the [experimental fs module](ht | Parameter | Type | Default | Description | | ------------------- | ----------- | ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| file | object | `null` | This is a mandatory parameter. | -| file.name | string | `''` | The name of the file e.g. `file.txt`. | -| file.mimeType | string | `''` | The type of the file content e.g. `text/plain`. | -| file.buffer | ArrayBuffer | `[]` | base64 encoded content of the file. | +| file | object | `null` | This is a required parameter. | +| file.name | string | `''` | The name of the file. For example, `file.txt`. | +| file.mimeType | string | `''` | The type of the file content. For example, `text/plain`. | +| file.buffer | ArrayBuffer | `[]` | Base64 encoded content of the file. | | options | object | `null` | This is an optional parameter. | | options.noWaitAfter | boolean | `false` | If set to `true` and a navigation occurs from performing this action, it will not wait for it to complete. | | options.timeout | number | `30000` | Maximum time in milliseconds. Pass `0` to disable the timeout. Default is overridden by the `setDefaultTimeout` option on [BrowserContext](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/browsercontext/) or [Page](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/page/). | diff --git a/docs/sources/next/javascript-api/k6-experimental/browser/frame/setinputfiles.md b/docs/sources/next/javascript-api/k6-experimental/browser/frame/setinputfiles.md index e0775a9e81..b8d2c1a585 100644 --- a/docs/sources/next/javascript-api/k6-experimental/browser/frame/setinputfiles.md +++ b/docs/sources/next/javascript-api/k6-experimental/browser/frame/setinputfiles.md @@ -12,10 +12,10 @@ To work with local files on the file system, use the [experimental fs module](ht | Parameter | Type | Default | Description | | ------------------- | ----------- | ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | selector | string | `''` | A selector to search for an element. If there are multiple elements satisfying the selector, the first will be used. | -| file | object | `null` | This is a mandatory parameter. | -| file.name | string | `''` | The name of the file e.g. `file.txt`. | -| file.mimeType | string | `''` | The type of the file content e.g. `text/plain`. | -| file.buffer | ArrayBuffer | `[]` | base64 encoded content of the file. | +| file | object | `null` | This is a required parameter. | +| file.name | string | `''` | The name of the file. For example, `file.txt`. | +| file.mimeType | string | `''` | The type of the file content. For example, `text/plain`. | +| file.buffer | ArrayBuffer | `[]` | Base64 encoded content of the file. | | options | object | `null` | This is an optional parameter. | | options.noWaitAfter | boolean | `false` | If set to `true` and a navigation occurs from performing this action, it will not wait for it to complete. | | options.timeout | number | `30000` | Maximum time in milliseconds. Pass `0` to disable the timeout. Default is overridden by the `setDefaultTimeout` option on [BrowserContext](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/browsercontext/) or [Page](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/page/). | diff --git a/docs/sources/next/javascript-api/k6-experimental/browser/page/setinputfiles.md b/docs/sources/next/javascript-api/k6-experimental/browser/page/setinputfiles.md index 75b350ff90..6a8f707da1 100644 --- a/docs/sources/next/javascript-api/k6-experimental/browser/page/setinputfiles.md +++ b/docs/sources/next/javascript-api/k6-experimental/browser/page/setinputfiles.md @@ -12,10 +12,10 @@ To work with local files on the file system, use the [experimental fs module](ht | Parameter | Type | Default | Description | | ------------------- | ----------- | ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | selector | string | `''` | A selector to search for an element. If there are multiple elements satisfying the selector, the first will be used. | -| file | object | `null` | This is a mandatory parameter. | -| file.name | string | `''` | The name of the file e.g. `file.txt`. | -| file.mimeType | string | `''` | The type of the file content e.g. `text/plain`. | -| file.buffer | ArrayBuffer | `[]` | base64 encoded content of the file. | +| file | object | `null` | This is a required parameter. | +| file.name | string | `''` | The name of the file. For example, `file.txt`. | +| file.mimeType | string | `''` | The type of the file content. For example, `text/plain`. | +| file.buffer | ArrayBuffer | `[]` | Base64 encoded content of the file. | | options | object | `null` | This is an optional parameter. | | options.noWaitAfter | boolean | `false` | If set to `true` and a navigation occurs from performing this action, it will not wait for it to complete. | | options.timeout | number | `30000` | Maximum time in milliseconds. Pass `0` to disable the timeout. Default is overridden by the `setDefaultTimeout` option on [BrowserContext](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/browsercontext/) or [Page](https://grafana.com/docs/k6//javascript-api/k6-experimental/browser/page/). |