Scrape_configs: retain cAdvisor metrics for system processes #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CPU metrics for Kubelet, Containerd, etc. are dropped by a relabel rule since they don't have a container image. On most systems they run in their own cgroup called `system.slice`, so we can add another rule which uses that fact to give the `image` label a value and then they won't be dropped.
bboreham
force-pushed
the
system-slice-metrics
branch
from
8c9653b to
aeba5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CPU metrics for Kubelet, Containerd, etc. are dropped by a relabel rule since they don't have a container image.
On most systems they run in their own cgroup called
system.slice, so we can add another rule which uses that fact to give theimagelabel a value and then they won't be dropped.Same change was made here a while back: grafana/agent#4048