remove azure virtual network dashboard not useful with DDos metrics (#1429)

Author: yduartep

csp-mixin/.lint

@@ -14,7 +14,6 @@ exclusions:
       reason: "Overview which is not filterable by instance"
     - dashboard: "Azure Load Balancing"
     - dashboard: "GCP Load Balancing"
-    - dashboard: "Azure Virtual network"
       reason: "resourceName is the instance label"
     - dashboard: "GCP Virtual private cloud"
       reason: "project_id is the instance label"
@@ -39,7 +38,6 @@ exclusions:
       reason: "Using 'resourceName' as instance label"
     - dashboard: "Azure Load Balancing"    
     - dashboard: "GCP Load Balancing"
-    - dashboard: "Azure Virtual network"
       reason: "resourceName is the instance label"
     - dashboard: "GCP Virtual private cloud"
       reason: "project_id is the instance label"
@@ -66,7 +64,6 @@ exclusions:
     # - dashboard: "Azure Elastic pool"
     # - dashboard: "Azure Blob storage"
     # - dashboard: "GCP Blob storage"
-    # - dashboard: "Azure Virtual network"
     #   reason: "False positive.. Need to look into this"
     # - dashboard: "GCP Virtual private cloud"
     #   reason: "False positive as above. Linter does not look at overrides."

csp-mixin/config.libsonnet

@@ -12,7 +12,6 @@
         gcploadbalancer: (import './signals/gcploadbalancer.libsonnet')(this),
         gcpoadbalancerBackend: (import './signals/gcpoadbalancerBackend.libsonnet')(this),
         azureloadbalancer: (import './signals/azureloadbalancer.libsonnet')(this),
-        azurevirtualnetwork: (import './signals/azurevirtualnetwork.libsonnet')(this),
         azurevm: (import './signals/azurevm.libsonnet')(this),
         azurevmOverview: (import './signals/azurevmOverview.libsonnet')(this),
         azurequeuestore: (import './signals/azurequeuestore.libsonnet')(this),

csp-mixin/dashboards.libsonnet

@@ -170,27 +170,6 @@ local commonlib = import 'common-lib/common/main.libsonnet';
                      )
                    ),
 
-                 [csplib.config.uid + '-virtualnetwork.json']:
-                   local variables = csplib.signals.azureloadbalancer.getVariablesMultiChoice();
-                   g.dashboard.new(csplib.config.dashboardNamePrefix + 'Virtual network')
-                   + g.dashboard.withUid(csplib.config.uid + '-virtualnetwork')
-                   + g.dashboard.withTags(csplib.config.dashboardTags)
-                   + g.dashboard.withTimezone(csplib.config.dashboardTimezone)
-                   + g.dashboard.withRefresh(csplib.config.dashboardRefresh)
-                   + g.dashboard.timepicker.withTimeOptions(csplib.config.dashboardPeriod)
-                   + g.dashboard.withVariables(variables)
-                   + g.dashboard.withPanels(
-                     g.util.grid.wrapPanels(
-                       g.util.panel.resolveCollapsedFlagOnRows(
-                         [
-                           csplib.grafana.rows.vn_overview,
-                           csplib.grafana.rows.vn_bytes,
-                           csplib.grafana.rows.vn_packets,
-                         ]
-                       )
-                     )
-                   ),
-
                  [csplib.config.uid + '-virtualmachines.json']:
                    local variables = csplib.signals.azurevm.getVariablesMultiChoice();
                    g.dashboard.new(csplib.config.dashboardNamePrefix + 'Virtual Machines')

csp-mixin/panels/azurevirtualnetwork.libsonnet

@@ -4,7 +4,6 @@
     azureloadbalancer: (import './azureloadbalancer.libsonnet').new(this),
     azurequeuestore: (import './azurequeuestore.libsonnet').new(this),
     azuresqldb: (import './azuresqldb.libsonnet').new(this),
-    azurevirtualnetwork: (import './azurevirtualnetwork.libsonnet').new(this),
     azurevm: (import './azurevm.libsonnet').new(this),
     blobstore: (import './blobstore.libsonnet').new(this),
     gcploadbalancer: (import './gcploadbalancer.libsonnet').new(this),

csp-mixin/panels/main.libsonnet

@@ -270,64 +270,6 @@ local g = import './g.libsonnet';
           ]
         ),
 
-      // Azure Virtual Network
-      vn_overview:
-        g.panel.row.new('Overview')
-        + g.panel.row.withCollapsed(false)
-        + g.panel.row.withPanels(
-          [
-            this.grafana.panels.azurevirtualnetwork.vn_under_ddos
-            + g.panel.timeSeries.gridPos.withW(6)
-            + g.panel.timeSeries.gridPos.withH(6),
-
-            this.grafana.panels.azurevirtualnetwork.vn_pingmesh_avg
-            + g.panel.timeSeries.gridPos.withW(6)
-            + g.panel.timeSeries.gridPos.withH(6),
-
-            this.grafana.panels.azurevirtualnetwork.vn_packet_trigger
-            + g.panel.timeSeries.gridPos.withW(12)
-            + g.panel.timeSeries.gridPos.withH(6),
-          ]
-        ),
-
-      vn_bytes:
-        g.panel.row.new('Bytes')
-        + g.panel.row.withCollapsed(false)
-        + g.panel.row.withPanels(
-          [
-            this.grafana.panels.azurevirtualnetwork.vn_bytes_by_action
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-
-            this.grafana.panels.azurevirtualnetwork.vn_bytes_dropped_by_protocol
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-
-            this.grafana.panels.azurevirtualnetwork.vn_bytes_forwarded_by_protocol
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-          ]
-        ),
-
-      vn_packets:
-        g.panel.row.new('Packets')
-        + g.panel.row.withCollapsed(false)
-        + g.panel.row.withPanels(
-          [
-            this.grafana.panels.azurevirtualnetwork.vn_packets_by_action
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-
-            this.grafana.panels.azurevirtualnetwork.vn_packets_dropped_by_protocol
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-
-            this.grafana.panels.azurevirtualnetwork.vn_packets_forwarded_by_protocol
-            + g.panel.timeSeries.gridPos.withW(8)
-            + g.panel.timeSeries.gridPos.withH(8),
-          ]
-        ),
-
       // Azure Virtual Machines
       avm_overview:
         g.panel.row.new('Overview')