Merge pull request #29 from grafana/svennergr/navigate-tools

add navigate to other and fix other navigate tools

Author: svennergr

public/app/features/dash/agent/tools/index.ts

@@ -6,6 +6,7 @@ import { lokiLabelValuesTool } from './lokiLabelValues';
 import { navigateToDashboardTool } from './navigateToDashboard';
 import { navigateToDrilldownLogs } from './navigateToDrilldownLogs';
 import { navigateToExploreTool } from './navigateToExplore';
+import { navigateToOtherTool } from './navigateToOther';
 import { prometheusInstantQueryTool } from './prometheusInstantQuery';
 import { prometheusLabelNamesTool } from './prometheusLabelNames';
 import { prometheusLabelValuesTool } from './prometheusLabelValues';
@@ -24,6 +25,7 @@ export const tools = [
   navigateToDrilldownLogs,
   getCurrentTimeTool,
   navigateToDashboardTool,
+  navigateToOtherTool,
 ];
 
 export const toolsByName = tools.reduce(

public/app/features/dash/agent/tools/navigateToDashboard.ts

@@ -9,11 +9,12 @@ const navigateToDashboardToolSchema = z.object({
   dashboard_uid: z.string().optional().describe('UID of the dashboard'),
   dashboard_title: z.string().optional().describe('Title of the dashboard'),
   dashboard_tag: z.string().optional().describe('String tag that labels the dashboard'),
+  navigate: z.boolean().describe('Whether to navigate to the dashboard. Only ever set this to true if the user has confirmed to navigate to the dashboard.'),
 });
 
 export const navigateToDashboardTool = tool(
   async (input) => {
-    const { dashboard_uid, dashboard_title, dashboard_tag } = navigateToDashboardToolSchema.parse(input);
+    const { dashboard_uid, dashboard_title, dashboard_tag, navigate } = navigateToDashboardToolSchema.parse(input);
 
     if (!dashboard_uid && !dashboard_title && !dashboard_tag) {
       return 'Failure. Ask the user which dashboard they want to see.';
@@ -36,9 +37,12 @@ export const navigateToDashboardTool = tool(
       return 'Failure. Tell the user that the dashboard does not exist';
     }
 
-    locationService.push(dashboard.url);
+    const url = dashboard.url;
+    if (navigate) {
+      locationService.push(url);
+    }
 
-    return 'success';
+    return url;
   },
   {
     name: 'navigate_to_dashboard',

public/app/features/dash/agent/tools/navigateToDrilldownLogs.ts

@@ -16,20 +16,22 @@ const navigateToDrilldownLogsSchema = z.object({
     .array(z.enum(['critical', 'error', 'debug', 'info', 'warning', 'fatal']))
     .optional()
     .describe('Array of error levels to include in the filters.'),
+  navigate: z.boolean().describe('Whether to navigate to the Drilldown Logs page. Only ever set this to true if the user has confirmed to navigate to Drilldown Logs.'),
 });
 
 export const navigateToDrilldownLogs = tool(
   async (input) => {
-    const { datasource_uid, label_filters, levels = [] } = navigateToDrilldownLogsSchema.parse(input);
+    const { datasource_uid, label_filters, levels = [], navigate } = navigateToDrilldownLogsSchema.parse(input);
 
     const varFilters = label_filters.map((filter) => `var-filters=${encodeURIComponent(filter)}`);
     const varLevels = levels.map((level) => `var-levels=${encodeURIComponent(`detected_level|=|${level}`)}`);
 
-    locationService.push(
-      `/a/grafana-lokiexplore-app/explore/service_name/grafana/logs?from=now-15m&to=now&var-ds=${datasource_uid}&${varFilters.join('&')}&${varLevels.join('&')}`
-    );
+    const url = `/a/grafana-lokiexplore-app/explore/service_name/grafana/logs?from=now-15m&to=now&var-ds=${datasource_uid}&${varFilters.join('&')}&${varLevels.join('&')}`;
+    if (navigate) {
+      locationService.push(url);
+    }
 
-    return 'success';
+    return url;
   },
   {
     name: 'navigate_to_drilldown_logs',

public/app/features/dash/agent/tools/navigateToExplore.ts

@@ -10,11 +10,12 @@ import { lokiOrPrometheusTypeRefiner } from './refiners';
 const navigateToExploreSchema = z.object({
   datasource_uid: z.string().describe('Datasource UID that will execute the query').refine(lokiOrPrometheusTypeRefiner.func, lokiOrPrometheusTypeRefiner.message),
   query: z.string().describe('Query to be executed'),
+  navigate: z.boolean().describe('Whether to navigate to the Explore page. Only ever set this to true if the user has confirmed to navigate to Explore.'),
 });
 
 export const navigateToExploreTool = tool(
   async (input) => {
-    const { datasource_uid, query } = navigateToExploreSchema.parse(input);
+    const { datasource_uid, query, navigate } = navigateToExploreSchema.parse(input);
     const type = getDatasourceSrv().getAll().find((ds) => ds.uid === datasource_uid)?.type;
 
     const panes = {
@@ -37,9 +38,12 @@ export const navigateToExploreTool = tool(
       },
     };
 
-    locationService.push(`/explore?schemaVersion=1&panes=${JSON.stringify(panes)}`);
+    const url = `/explore?schemaVersion=1&panes=${JSON.stringify(panes)}`;
+    if (navigate) {
+      locationService.push(url);
+    }
 
-    return 'success';
+    return url;
   },
   {
     name: 'navigate_to_explore',

public/app/features/dash/agent/tools/navigateToOther.ts

@@ -0,0 +1,27 @@
+import { tool } from '@langchain/core/tools';
+import { z } from 'zod';
+
+import { locationService } from '@grafana/runtime';
+
+const navigateToOtherSchema = z.object({
+  url: z.string().describe('URL to navigate to'),
+  navigate: z.boolean().describe('Whether to navigate to the URL. Only ever set this to true if the user has confirmed to navigate to the URL.'),
+});
+
+export const navigateToOtherTool = tool(
+  async (input) => {
+    const { url, navigate } = navigateToOtherSchema.parse(input);
+
+    if (navigate) {
+      locationService.push(url);
+    }
+
+    return url;
+  },
+  {
+    name: 'navigate_to_other',
+    description:
+      'Use this tool when the user wants to navigate to a URL. NEVER use it without asking the user for confirmation.',
+    schema: navigateToOtherSchema,
+  }
+);