add spanish trans test

Author: sunker

examples/panel-basic/src/loadResources.ts

@@ -11,6 +11,7 @@ export const loadResources: ResourceLoader = async (resolvedLanguage: string) =>
     const translation = await resources[resolvedLanguage]();
     return translation.default;
   } catch (error) {
+    // This makes sure that the plugin doesn't crash when the resolved language in Grafana isn't supported by the plugin
     console.error(`The plugin '${pluginJson.id}' doesn't support the language '${resolvedLanguage}'`, error);
     return {};
   }

examples/panel-basic/src/module.ts

@@ -11,7 +11,7 @@ import { loadResources } from 'loadResources';
 // Before Grafana version 12.1.0 the plugin is responsible for loading translation resources
 // In Grafana version 12.1.0 and later Grafana is responsible for loading translation resources
 const loaders = semver.lt(config?.buildInfo?.version, '12.1.0') ? [loadResources] : [];
-initPluginTranslations(pluginJson.id, loaders);
+await initPluginTranslations(pluginJson.id, loaders);
 
 export const plugin = new PanelPlugin<SimpleOptions>(SimplePanel).setPanelOptions((builder) => {
   return builder

examples/panel-basic/tests/translations/spanish.spec.ts

@@ -0,0 +1,25 @@
+import { expect, test } from '@grafana/plugin-e2e';
+
+test.use({
+  featureToggles: {
+    localizationForPlugins: true,
+  },
+  userPreferences: {
+    language: 'es-ES',
+  },
+});
+
+test('should display Spanish plugin translations', async ({ gotoPanelEditPage, readProvisionedDashboard, page }) => {
+  const dashboard = await readProvisionedDashboard({ fileName: 'dashboard.json' });
+  const panelEditPage = await gotoPanelEditPage({ dashboard, id: '1' });
+  await page.evaluate(() => {
+    console.log('lang', (window as any).grafanaBootData?.user?.language);
+    console.log('toggles', (window as any).grafanaBootData?.settings.featureToggles);
+  });
+
+  // For Grafana v11+, expect Spanish translations
+  await expect(panelEditPage.panel.locator.getByText('Valor de la opción de texto:')).toBeVisible();
+  const options = panelEditPage.getCustomOptions('Basic');
+  const showSeriesCounter = options.getSwitch('Mostrar contador de series');
+  await expect(showSeriesCounter.locator()).toBeVisible();
+});

examples/panel-basic/tests/translations/swedish.spec.ts

@@ -1,5 +1,3 @@
-import * as semver from 'semver';
-
 import { expect, test } from '@grafana/plugin-e2e';
 
 test.use({
@@ -11,32 +9,17 @@ test.use({
   },
 });
 
-test('should display correct translation based on Grafana version (Swedish for v11+, English fallback for <v11)', async ({
-  gotoPanelEditPage,
-  readProvisionedDashboard,
-  grafanaVersion,
-  page,
-}) => {
+test('should display Swedish plugin translations', async ({ gotoPanelEditPage, readProvisionedDashboard, page }) => {
   const dashboard = await readProvisionedDashboard({ fileName: 'dashboard.json' });
   const panelEditPage = await gotoPanelEditPage({ dashboard, id: '1' });
   await page.evaluate(() => {
     console.log('lang', (window as any).grafanaBootData?.user?.language);
     console.log('toggles', (window as any).grafanaBootData?.settings.featureToggles);
   });
 
-  const isVersion11OrHigher = semver.gte(grafanaVersion, '11.0.0');
-
-  if (isVersion11OrHigher) {
-    // For Grafana v11+, expect Swedish translations
-    await expect(panelEditPage.panel.locator.getByText('Textalternativ värde:')).toBeVisible();
-    const options = panelEditPage.getCustomOptions('Basic');
-    const showSeriesCounter = options.getSwitch('Visa serieräknare');
-    await expect(showSeriesCounter.locator()).toBeVisible();
-  } else {
-    // For Grafana <v11, expect English fallback
-    await expect(panelEditPage.panel.locator.getByText('Text option value:')).toBeVisible();
-    const options = panelEditPage.getCustomOptions('Basic');
-    const showSeriesCounter = options.getSwitch('Show series counter');
-    await expect(showSeriesCounter.locator()).toBeVisible();
-  }
+  // For Grafana v11+, expect Swedish translations
+  await expect(panelEditPage.panel.locator.getByText('Textalternativ värde:')).toBeVisible();
+  const options = panelEditPage.getCustomOptions('Basic');
+  const showSeriesCounter = options.getSwitch('Visa serieräknare');
+  await expect(showSeriesCounter.locator()).toBeVisible();
 });