-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate API docs #521
Conversation
* Update makefile and auto run after test, this way they are always run by a developer * Add to CI to check for dirty file-system * Create documentation/api/ to store the new api docs. * Solves: grafana#519
The main question is if we like this kind of docs, unless you have a markdown previewer in your IDE it's more or less useless. Since crdoc generates the data from the CRD it shows a few places where we should improve the comments in the .go files that generates the CRD:s. The bad thing with crdoc is that it isn't possible to add comments in to it and that is something that other code generators can handle. But as I mentioned in the issue, the other ones don't generated markdown. So yeah please come with feedback, if we don't like this solution lets try to come up with something else :) |
I like this solution, I think it's a much neater way of presenting the information that's already there, a lot of it is self-explanatory, but there are, as you pointed out, places where we need to improve our crd docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NissesSenap, I really like this change.
One small thing, can you hyperlink the API doc to the main README? let's make it more visible, it might be hard to find otherwise (let's not hide your contribution 😅 )
Looks good to me! Once you hyperlink, feel free to merge!
Fix minor markdown linting errors
Description
Relevant issues/tickets
#519
#502
Type of change
Checklist
Verification steps