Skip to content

fix: allow sending isDisabled=false in UpdateServiceAccountForm #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow sending isDisabled=false in UpdateServiceAccountForm #115

wants to merge 1 commit into from

Conversation

ndk
Copy link

@ndk ndk commented May 7, 2025 •
edited
Loading

Problem

The client couldn't disable a service account: the generated struct omitted isDisabled when set to false, so Grafana read it as unchanged.

Fix

During schema pull it now marks UpdateServiceAccountForm.isDisabled as x-nullable=true.
After codegen the field is *bool, so:

  • nil - don't touch the flag
  • true - disable account
  • false - enable account

Notes

@ndk ndk requested a review from a team as a code owner May 7, 2025 14:00
@ndk ndk mentioned this pull request May 7, 2025
Closed
@ndk ndk mentioned this pull request Jun 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndk