test(kv): create mock client for counting func calls #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
reviewed
Nov 14, 2024
NickAnge
force-pushed
the
nickange/kv/test-add-custom-mock-client
branch
2 times, most recently
from
c794533 to
3b9b7b9
Compare
56quarters
approved these changes
Nov 14, 2024
NickAnge
force-pushed
the
nickange/kv/test-add-custom-mock-client
branch
from
3b9b7b9 to
3b5ceaa
Compare
NickAnge
force-pushed
the
nickange/kv/test-add-custom-mock-client
branch
from
3b5ceaa to
9e8cce4
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR creates a
MockCountingClient, which wraps thekv.clientand can be use in order to count calls at specific functions of the interface.This will be used here for testing purposes
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]