Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1444 to 1.9 #1445

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

grcevski
Copy link
Contributor

Backports the fixes to #1444 to 1.9

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (4a34748) to head (bf39767).
Report is 3 commits behind head on release-1.9.

Files with missing lines Patch % Lines
pkg/kubecache/meta/informers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1445      +/-   ##
===============================================
- Coverage        80.96%   80.95%   -0.02%     
===============================================
  Files              146      146              
  Lines            14774    14774              
===============================================
- Hits             11962    11960       -2     
- Misses            2229     2231       +2     
  Partials           583      583              
Flag Coverage Δ
integration-test 58.52% <0.00%> (+0.01%) ⬆️
k8s-integration-test 59.84% <80.00%> (-0.05%) ⬇️
oats-test 34.00% <0.00%> (ø)
unittests 51.75% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 2580eb9 into grafana:release-1.9 Dec 12, 2024
13 checks passed
@grcevski grcevski deleted the 1.9-fix_missing_service_info branch December 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants