Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grafana/beyla
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 915de0723ed207ffde81864978d16cfd9fc42749
Choose a base ref
...
head repository: grafana/beyla
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a29c198ff7a9646bb6d2315972a54dd9a1c9d9e
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 20, 2024

  1. Treat go binaries without offsets as generic 

    There is a small corner case in which we detect no go offsets in a
target executable, but if that executable happens to have a ".gosyms"
section, we will end up classifying it as a Go executable, causing
issues. We attach an error in this case to have the attacher treat it as
a generic executable.
    @rafaelroquetto
    rafaelroquetto committed Dec 20, 2024
    Configuration menu
    Copy the full SHA
    783f820 View commit details
    Browse the repository at this point in the history

  2. Fixes panic on Go instrumentation 

    On ELF parse error, we return the list of missing fields, assuming that
we would stop the instrumentation. There is an edge case error on which
the missing fields set is empty so Beyla keeps with the instrumentation,
but the returned list of fields is nil.
    @mariomac @rafaelroquetto
    mariomac authored and rafaelroquetto committed Dec 20, 2024
    Configuration menu
    Copy the full SHA
    85b0c47 View commit details
    Browse the repository at this point in the history

  3. Treat Go proxies as generic binaries 

    In the case in which we have found offsets, but these are related to a
go proxy, we must set the error so that the attacher will treat this as
a regular binary.
    @rafaelroquetto
    rafaelroquetto committed Dec 20, 2024
    Configuration menu
    Copy the full SHA
    2a29c19 View commit details
    Browse the repository at this point in the history
Loading