Refactor + fix request sender used by Alertmanager notifier #321
+177
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwwiv
commented
May 2, 2025
Comment on lines
+194
to
+195
| // Disable keep alive since this is a short lived client | ||
| DisableKeepAlives: true, |
There was a problem hiding this comment.
This is the line that fixes the bug mentioned in the PR desc.
rwwiv
changed the title
Disable keep alives and add test to verify Fix lint
moustafab
force-pushed
the
rwwiv/am-receiver-sender-cleanup
branch
from
e434b6c to
556b394
Compare
|
Is this PR still being worked on? We would really appreciate if it least the fix could be merged because we are affected by this issue too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
util.go(i.e. sendHTTPRequest) in favor of an interface (Sender) with the intention that this be the first step towards pulling this code out of the library.