Skip to content

Commit 0223509

Browse files
Add argument for decode function to BuildReceiverIntegrations (#344)
1 parent 172b54d commit 0223509

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

notify/factory.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ func BuildReceiversIntegrations(
253253
templ TemplatesProvider,
254254
images images.Provider,
255255
decryptFn GetDecryptedValueFn,
256+
decodeFn DecodeSecretsFn,
256257
emailSender receivers.EmailSender,
257258
httpClientOptions []http.ClientOption,
258259
notifierFunc WrapNotifierFunc,
@@ -273,7 +274,7 @@ func BuildReceiversIntegrations(
273274

274275
integrationsMap := make(map[string][]*Integration, len(apiReceivers))
275276
for name, apiReceiver := range nameToReceiver {
276-
integrations, err := BuildReceiverIntegrations(tenantID, apiReceiver, templ, images, decryptFn, emailSender, httpClientOptions, notifierFunc, version, logger)
277+
integrations, err := BuildReceiverIntegrations(tenantID, apiReceiver, templ, images, decryptFn, decodeFn, emailSender, httpClientOptions, notifierFunc, version, logger)
277278
if err != nil {
278279
return nil, fmt.Errorf("failed to build receiver %s: %w", name, err)
279280
}
@@ -290,6 +291,7 @@ func BuildReceiverIntegrations(
290291
tmpls TemplatesProvider,
291292
images images.Provider,
292293
decryptFn GetDecryptedValueFn,
294+
decodeFn DecodeSecretsFn,
293295
emailSender receivers.EmailSender,
294296
httpClientOptions []http.ClientOption,
295297
wrapNotifierFunc WrapNotifierFunc,
@@ -298,7 +300,7 @@ func BuildReceiverIntegrations(
298300
) ([]*Integration, error) {
299301
var integrations []*Integration
300302
if len(receiver.Integrations) > 0 {
301-
receiverCfg, err := BuildReceiverConfiguration(context.Background(), receiver, DecodeSecretsFromBase64, decryptFn)
303+
receiverCfg, err := BuildReceiverConfiguration(context.Background(), receiver, decodeFn, decryptFn)
302304
if err != nil {
303305
return nil, err
304306
}

notify/factory_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ func TestBuildReceiversIntegrations(t *testing.T) {
157157
tmpl,
158158
imageProvider,
159159
NoopDecrypt,
160+
NoopDecode,
160161
emailService,
161162
nil,
162163
func(_ string, n notify.Notifier) notify.Notifier {
@@ -202,6 +203,7 @@ func TestBuildReceiversIntegrations(t *testing.T) {
202203
tmpl,
203204
imageProvider,
204205
NoopDecrypt,
206+
NoopDecode,
205207
emailService,
206208
nil,
207209
func(_ string, n notify.Notifier) notify.Notifier {

notify/grafana_alertmanager.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,7 @@ func (am *GrafanaAlertmanager) ApplyConfig(cfg NotificationsConfiguration) (err
691691
cached,
692692
am.opts.ImageProvider,
693693
am.opts.Decrypter,
694+
DecodeSecretsFromBase64,
694695
am.opts.EmailSender,
695696
nil,
696697
NoWrap,
@@ -938,6 +939,7 @@ func (am *GrafanaAlertmanager) buildReceiverIntegrations(receiver *APIReceiver,
938939
tmpls,
939940
am.opts.ImageProvider,
940941
am.opts.Decrypter,
942+
DecodeSecretsFromBase64,
941943
am.opts.EmailSender,
942944
nil,
943945
NoWrap,

0 commit comments

Comments
 (0)