Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(agentctl): add inspect flag in test-logs cmd #6836

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fgouteroux
Copy link
Contributor

PR Description

Hi,

I would like to add the --inspect flag from promtail to grafana-agentctl test-logs command, like explain in the doc.

$ grafana-agentctl test-logs -h

Starts Promtail using its '--dry-run' flag, which will only print logs instead of sending them to the remote server.
		This can be useful for debugging and understanding how logs are being parsed.

Usage:
  agentctl test-logs [config file] [flags]

Flags:
  -h, --help      help for test-logs
  -i, --inspect   Allows for detailed inspection of pipeline stages.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@fgouteroux fgouteroux force-pushed the feat/agentctl_test_logs_inspect branch 3 times, most recently from 11525df to 43038c1 Compare April 9, 2024 13:59
@rfratto rfratto added variant/static Related to Grafana Agent Static. enhancement New feature or request labels Apr 9, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 10, 2024
@fgouteroux fgouteroux closed this Jun 10, 2024
@fgouteroux fgouteroux force-pushed the feat/agentctl_test_logs_inspect branch from 4e5077f to ad83d1e Compare June 10, 2024 07:17
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
@fgouteroux fgouteroux reopened this Jun 10, 2024
@fgouteroux
Copy link
Contributor Author

Hello, any chance to get this merged ?

@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Jun 13, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention. variant/static Related to Grafana Agent Static.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants