Skip to content

Commit ea1147f

Browse files
committed
fix: switch boolean expression
1 parent 5b276d4 commit ea1147f

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/main/java/org/gradlex/javamodule/packaging/tasks/Jpackage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ private void configureJPackageArguments(ExecSpec e, Directory resourcesDir) {
268268
if (!getAddModules().get().isEmpty()) {
269269
e.args("--add-modules", String.join(",", getAddModules().get()));
270270
}
271-
if (!getVerbose().get()) {
271+
if (getVerbose().get()) {
272272
e.args("--verbose");
273273
}
274274
}

src/test/java/org/gradlex/javamodule/packaging/test/JavaModulePackagingOptionsTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
package org.gradlex.javamodule.packaging.test;
33

44
import static org.assertj.core.api.Assertions.assertThat;
5-
import static org.gradlex.javamodule.packaging.test.fixture.GradleBuild.runsOnLinux;
65

76
import org.gradlex.javamodule.packaging.test.fixture.GradleBuild;
87
import org.junit.jupiter.api.BeforeEach;
@@ -110,14 +109,13 @@ void can_configure_add_modules() {
110109

111110
@Test
112111
void can_set_verbose_option() {
113-
var v = runsOnLinux() ? "true" : "false";
114112
build.appBuildFile.appendText("""
115113
javaModulePackaging {
116-
verbose.set(%s)
114+
verbose.set(true)
117115
}
118-
""".formatted(v));
116+
""");
119117

120-
var result = build.runner(":app:jpackage", "-q").build();
118+
var result = build.build(":app:jpackage");
121119

122120
assertThat(result.getOutput()).contains("Creating app package: ");
123121
}

src/test/java/org/gradlex/javamodule/packaging/test/JavaModulePackagingResourcesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ void can_add_resources_for_jpackage() {
9696

9797
String icon = "app.icns";
9898
if (runsOnLinux()) icon = "app.png";
99-
if (runsOnWindows()) icon = "app.icoxxx";
99+
if (runsOnWindows()) icon = "app.ico";
100100

101101
// Intermediate location to collect files
102102
assertThat(build.file("app/build/tmp/jpackage/%s/jpackage-resources/dummy.txt".formatted(currentTarget()))

0 commit comments

Comments
 (0)