Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Dataset page to 0 when samples change #9093

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Reset Dataset page to 0 when samples change #9093

merged 3 commits into from
Aug 12, 2024

Conversation

abidlabs
Copy link
Member

Resets the page of the Dataset component to page 0 when the samples change, preventing issues like this: #9083

Closes: #9083

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/c3bae58d327b7d67939c36734ef4ccb793013e64/gradio-4.41.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c3bae58d327b7d67939c36734ef4ccb793013e64#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/c3bae58d327b7d67939c36734ef4ccb793013e64/gradio-client-1.5.0.tgz

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataset patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Reset Dataset page to 0 when samples change

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm!

@abidlabs
Copy link
Member Author

Thanks @aliabid94!

@abidlabs abidlabs merged commit 60650d8 into main Aug 12, 2024
19 checks passed
@abidlabs abidlabs deleted the dataset-reset branch August 12, 2024 22:12
This was referenced Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update gr.Examples component,get an error which is list index out of range.
3 participants