Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gr.ParamViewer to use HTML <details> and other tweaks #8744

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

abidlabs
Copy link
Member

Refactors gr.ParamViewer to use HTML <details> which provides this nice functionality that the gr.ParamViewer expands when search terms. I also added an optional header to the ParamViewer that includes a global toggle button.

Screen.Recording.2024-07-10.at.3.23.55.PM.mov

@abidlabs abidlabs requested a review from pngwn July 10, 2024 22:26
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 10, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/54563767e7ca418a3af9f3a1a87705c69ef14ccc/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@54563767e7ca418a3af9f3a1a87705c69ef14ccc#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/54563767e7ca418a3af9f3a1a87705c69ef14ccc/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 10, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/paramviewer patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Refactor gr.ParamViewer to use HTML <details> and other tweaks

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jul 10, 2024
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@abidlabs
Copy link
Member Author

Thanks @aliabd for the review! I'm going to go ahead and merge this in so that I can incorporate in #8618, but @pngwn lmk if you have any other feedback.

@abidlabs abidlabs merged commit b736c8d into main Jul 11, 2024
8 checks passed
@abidlabs abidlabs deleted the param-details branch July 11, 2024 00:58
@pngwn pngwn mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants