Skip to content

Commit

Permalink
test: add withConn tests
Browse files Browse the repository at this point in the history
  • Loading branch information
DomParfitt committed Nov 3, 2022
1 parent 5350c18 commit a54ed5a
Showing 1 changed file with 81 additions and 0 deletions.
81 changes: 81 additions & 0 deletions with_conn_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
package redis

import (
"context"

"github.com/go-redis/redis/v9/internal/pool"
"github.com/go-redis/redis/v9/internal/proto"

. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)

type timeoutErr struct {
error
}

func (e timeoutErr) Timeout() bool {
return true
}

func (e timeoutErr) Temporary() bool {
return true
}

func (e timeoutErr) Error() string {
return "i/o timeout"
}

var _ = Describe("withConn", func() {
var client *Client

BeforeEach(func() {
client = NewClient(&Options{
PoolSize: 1,
})
})

AfterEach(func() {
client.Close()
})

It("should replace the connection in the pool when there is no error", func() {
var conn *pool.Conn

client.withConn(ctx, func(ctx context.Context, c *pool.Conn) error {
conn = c
return nil
})

newConn, err := client.connPool.Get(ctx)
Expect(err).To(BeNil())
Expect(newConn).To(Equal(conn))
})

It("should replace the connection in the pool when there is an error not related to a bad connection", func() {
var conn *pool.Conn

client.withConn(ctx, func(ctx context.Context, c *pool.Conn) error {
conn = c
return proto.RedisError("LOADING")
})

newConn, err := client.connPool.Get(ctx)
Expect(err).To(BeNil())
Expect(newConn).To(Equal(conn))
})

It("should remove the connection from the pool when it times out", func() {
var conn *pool.Conn

client.withConn(ctx, func(ctx context.Context, c *pool.Conn) error {
conn = c
return timeoutErr{}
})

newConn, err := client.connPool.Get(ctx)
Expect(err).To(BeNil())
Expect(newConn).NotTo(Equal(conn))
Expect(client.connPool.Len()).To(Equal(1))
})
})

0 comments on commit a54ed5a

Please sign in to comment.