Allow the test classes directory to be configured for the NativeTestMojo #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
vjovanov
reviewed
Aug 6, 2025
| <skip>false</skip> | ||
| <imageName>${imageName}</imageName> | ||
| <fallback>false</fallback> | ||
| <testClassesDirectory>${project.build.outputDirectory}</testClassesDirectory> |
There was a problem hiding this comment.
I am wondering if we can go without an extra parameter. How does the surefire plugin know the test-classes path?
There was a problem hiding this comment.
Surefire and Failsafe both assume that the tests are in the default locations. But both have an optional <testClassesDirectory> configuration element that allows you to set a different location. In our case we have test modules where that only contain tests and the source is all under src/main/java and gets compiled to target/classes so we have to tell Surefire and Failsafe to use these directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NativeTestMojohard codes the location of the test classes to be theproject.build.testOutputDirectory. Some Maven projects have test classes in other locations, for example undersrc/main/javawhich compiles them to theproject.build.outputDirectory.This PR allows the test classes location to be configured for the
NativeTestMojoin the same way that plugins such as Surefire and Failsafe do by setting the<testClassesDirectory>element in the plugin configuration. The default is theproject.build.testOutputDirectory.