-
Notifications
You must be signed in to change notification settings - Fork 77
Add runtimeArgs
support to native-maven-plugin
#734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
723580d
to
1453db7
Compare
native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/NativeTestMojo.java
Outdated
Show resolved
Hide resolved
native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/NativeTestMojo.java
Outdated
Show resolved
Hide resolved
With regards to testing this with Spock, you can use |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnestoro please help @linghengqian to write a test for this. The one added here is still skipped.
Other than that, this LGTM
@linghengqian thank you for your patience and collaboration!
@@ -5,6 +5,10 @@ | |||
|
|||
This version introduces a breaking change: the plugin now requires Java 17 to run. | |||
|
|||
=== Maven plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnestoro will this go into 0.11.0? If not, please adjust it
I believe that is because the test is annotated with @linghengqian sorry for the late response. Can you try something like this. You can calculate currently used version like this:
and then your
|
49973f0
to
9eab80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
After I set
GRAALVM_HOME
locally to24.0.1-graalce
ofvfox
, the results of./gradlew :native-maven-plugin:functionalTest
are normal. -
I will say that I am curious about the failed CI involving
JDK 26
at https://github.com/graalvm/native-build-tools/actions/runs/15781723681/job/44488746828?pr=734 , mainly I am not sure ifSDKMAN!
orfoojayio/discoapi
have JDK26 .vfox install java@26.ea.1-graal
doesn't work, which seems to mean https://github.com/graalvm/oracle-graalvm-ea-builds/releases/tag/jdk-26.0.0-ea.01 hasn't been uploaded tofoojayio/discoapi
yet? -
update in 2025.06.21: I see https://api.foojay.io/swagger-ui#/default/getDistributionsV3 is already documented for JDK 26. I'll investigate later on the
vfox
side.
819f0d0
to
c8ea3f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late response. Can you try something like this. You can calculate currently used version like this:
- It seems that starting from GraalVM CE Dev For JDK 25, in the printed Log,
org.graalvm.nativeimage.MissingReflectionRegistrationError
changed tocom.oracle.svm.core.jdk.resources.MissingReflectionRegistrationError
, I am not sure which commit of https://github.com/oracle/graal/blob/master/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/MissingRegistrationUtils.java caused this change. I changed the assertion slightly. - All done.
c8ea3f2
to
f344667
Compare
@linghengqian thanks for your contribution. From testing side it looks okay now. Since you force pushed commits, original approval from @alvarosanchez is dismissed. @alvarosanchez can you please re-approve the PR if it is still okay (since I don't know the previous state of PR and there is only one commit in history) |
native-maven-plugin
lacksruntimeArgs
configuration item similar tonative-gradle-plugin
#685 .native-maven-plugin
cannot publish to local repository on Windows with Simplified Chinese #735 .runtimeArgs
support tonative-maven-plugin
.native-maven-plugin
to local repository on Windows with Simplified Chinese../gradlew publishToMavenLocal --no-parallel
against https://github.com/linghengqian/jetcd-multi-platform-native-test andorg.graalvm.buildtools:native-maven-plugin:0.11.0-SNAPSHOT
. This even fixes the bug reported in [Native Image] Netty DNS Resolver is not available in GraalVM Native Image compiled on Windows oracle/graal#11280 where the unit tests never stopped.