Added ExtendBaseWith type for Rest API example #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
force-pushed
the
rest-api-extend-base-with
branch
from
e3c4e34 to
10b5525
Compare
|
@gr2m my local line ending settings on Windows are conflicting with Prettier's settings so I'm sending this in as a separate PR. Otherwise it should be ready for review! |
just for future reference: you can run |
gr2m
reviewed
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtendsBaseWithappliesdefaultsand/orpluginsfrom its type parameter onto a created type.I'm not positive I got exactly where to put those types right, so this might be a little off. More test cases should be added if so!