Replies: 1 comment
|
@amotarao thanks for the detailed write-up! I agree with the direction. The current setup makes the main package carry calendar specific dependencies even for users who never import those calendars, which isn’t ideal for long-term maintenance. I think splitting calendars into separate packages is the right path. I’ll open a tracking issue/RFC so we can define the migration details and roll it out safely. I’m also planning to release a v10 soon (mainly to remove old deprecated APIs), and it would be great to include this change in it. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Background
Since v9.14.0, react-day-picker ships the following calendar sub-exports:
To support the Hijri calendar, @tabby_ai/hijri-converter@1.0.5 was added as a production
dependency of the main package.
Concerns
Looking into this package:
It's difficult to assess the reliability and long-term maintenance of this package. More
importantly, as more calendars are added, users who don't use Hijri are still forced to install
its dependencies.
Proposal
Would it be worth considering publishing each calendar as an independent npm package?
@react-day-picker/hijri
@react-day-picker/persian
@react-day-picker/buddhist
@react-day-picker/hebrew
@react-day-picker/ethiopic
Benefits
Curious to hear your thoughts!
All reactions