-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--rerun-fails
always makes goleak and datarace errors pass after re-running
#442
Comments
Hello, thank you for the bug report! Can you try with The re-runs are done one test at a time because of some limitations with the The tests may be passing because the |
Thanks for the response! first variant with
rerun the same test:
Full log:
|
On the other side, the same test without the
|
Full logs can be found as part of this PR open-telemetry/opentelemetry-collector-contrib#35413 I created it just for showcasing the problem |
Hello, any news about this? |
1 similar comment
Hello, any news about this? |
Description
When using
--rerun-fails=1
option withgotestsum
, all of the tests pass. The behavior is very deterministic. Instead when removing the option, I am getting a lot ofgoleak
anddata-race
errors. It's quite interesting that the behavior with re-running the tests is very deterministic, as I would expect from a big number of tests and multiple runs, it should fail at least once also in the re-run. It seems to me that in the 2. run, thegotestsum
just ignores the errors which popped up during the first runThe text was updated successfully, but these errors were encountered: