-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added request headers to http tests #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks really good.
Build is failing because Travis is pinned to diff --git a/system/http.go b/system/http.go
index fc18225..7de0646 100644
--- a/system/http.go
+++ b/system/http.go
@@ -74,7 +74,7 @@ func (u *DefHTTP) setup() error {
if err != nil {
return u.err
}
- req.Header = u.RequestHeader.Clone()
+ req.Header = u.RequestHeader
if u.Username != "" || u.Password != "" {
req.SetBasicAuth(u.Username, u.Password)
} |
I'm fine with updating go if it doesn't break anything else. Feel free to submit a different PR for that or just tack it on this one. |
https://github.com/aelsabbahy/goss/blob/master/.travis.yml#L4 I think this is what you meant to change. |
Ahh that's what I was looking for! Want me to backout the changes on |
Can you point me to the docs on the go.mod change. Go has changed dep management systems so many times, I actually haven't read up on go.mod yet. Guess what I'm saying is, I don't understand the implications of the go.mod change you made. :) |
If you get this PR green today I'll probably cut a Goss release with it tomorrow. |
This is the best doc I've found to describe the |
Looks like the build if failing in Travis. I've noticed these fail locally prior to making any changes. If you think they're just flaky tests would you mind retrying the build in Travis so I don't have to push a no-op change? |
Count: 94, Failed: 0, Skipped: 5 The counts are mismatching since you added a test. |
Also, docs need to be updated. I'm doing quick eyeball review on my phone currently. |
Thanks for the document on go.mod, explained it very well. |
* Added request headers to http tests * Pinning go 1.13 * Pinning Travis version of go to 1.13 * Bumping the count of tests being run * Updating the docs to reflect new request headers
No description provided.