Skip to content

Conversation

@tflyons
Copy link
Contributor

@tflyons tflyons commented Sep 27, 2019

Fixes #121

Summary of Changes

  1. Add SameSite Modes to mirror http.SameSite values
  2. Add SameSite to options
  3. Split store into pre and post 1.11 versions to maintain backwards compatibility
  4. Option test for SameSite added

@elithrar
Copy link
Contributor

elithrar commented Sep 27, 2019 via email

@tflyons
Copy link
Contributor Author

tflyons commented Sep 27, 2019

My pleasure, looking forward to having the option. I'm out this weekend but can make any updates Sunday/Monday as needed

@tflyons
Copy link
Contributor Author

tflyons commented Oct 5, 2019

@elithrar circling back to see if you have some time to review

Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments:

• make the SameSite use-case clear to readers;
• Add a line to the README describing that it’s supported (and why it’s useful!).

Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] SameSite missing from Options?

2 participants