Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network requests not blocked for short period after browser start. #2970

Closed
kasper93 opened this issue Sep 4, 2017 · 9 comments
Closed

Network requests not blocked for short period after browser start. #2970

kasper93 opened this issue Sep 4, 2017 · 9 comments

Comments

@kasper93
Copy link
Contributor

kasper93 commented Sep 4, 2017

Describe the issue

Looks like browser can bypass uBlock for the short period of time, probably before extension is fully initialized. I noticed this when restarting browser for update, on session restore page will have ads not blocked.

One or more specific URLs where the issue occurs

I tested with hltv.org but any site will do.

Steps for anyone to reproduce the issue

  1. Go to any page where network request is blocked by uBlock.
  2. Restart browser - SHIFT+F2 and type restart --nocache
  3. Browser will restart and restore previous tabs. But loaded tab will not have ads blocked, because network request were made probably before uBlock is ready.

Your settings

  • OS/version: Windows 10
  • Browser/version: Firefox Nightly (20170904100131)
  • uBlock Origin version: 1.14.8
@kasper93 kasper93 changed the title Network requests not blocked some time after browser start. Network requests not blocked for short period after browser start. Sep 4, 2017
@Atavic
Copy link

Atavic commented Sep 4, 2017

It's a browser issue, open it in offline mode to prevent possible leaks.

@Atavic
Copy link

Atavic commented Sep 4, 2017

Also see: #1913

@uBlock-user
Copy link
Contributor

uBlock-user commented Sep 4, 2017

Open Advanced settings page, set suspendTabsUntilReady to true and restart browser.

@gorhill
Copy link
Owner

gorhill commented Sep 4, 2017

Duplicate of #1327.

@gwarser
Copy link
Contributor

gwarser commented Sep 4, 2017

Open Advanced settings page, set suspendTabsUntilReady to true and restart browser.

Sadly, not work for me any more.

  • Cookies must be allowed on UBO settings page, for this settings to be remembered between sessions. Offline Website Data must not be cleared on browser close.
  • Even with cookies allowed I end up with first tab and address bar being blank. URL only flashes for a moment and then disappear leaving first visible tab unusable.

@gorhill
Copy link
Owner

gorhill commented Sep 4, 2017

@gorhill
Copy link
Owner

gorhill commented Sep 4, 2017

Something else I could experiment with: Firefox's webRequest API allows to return Promise to tell whether a request should be blocked or not. uBO could make use of this and resolve all the pending Promises once all the filters are loaded. I have no clue if that would work though, just that conceptually that seems correct.

@luxoflux
Copy link

@gorhill
Did you ever get around to trying that experiment?

@luxoflux
Copy link

I found that setting the browser to clear cache on exit fixes this issue for me. Good enough.

Tested with 57b9 and 58.0a1 (2017-10-19).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants