"toggle cosmetic filtering" no longer affects net-blocked element collapsing

[kikaxa]

Recently since autoupdate to ~v1.5 rules like "no-cosmetic-filtering: 2ch.hk true" or eye icon in popup have no effect for me.

I have images/scripts blocked.
Previously, it showed placeholder/empty block for images, now it always hides them.

Can you see if it happens for you too?

[gorhill]

It's because the cosmetic filtering switch was not properly implemented, it was causing both cosmetic filters and the collapsing of blocked elements through network filtering to be disabled. The purpose of the cosmetic filtering switch is to toggle only cosmetic filters, not the collapse of the placeholder of blocked network requests.

One could disable cosmetic filtering globally (no-cosmetic-filtering: * true) in order to make uBO even more efficient by forcing uBO to disregard cosmetic filtering everywhere by default and activate on a per-site basis (a good performance boost for uBO on mobile devices), while still preserving the collapsing of blocked resources through network filtering.

[kikaxa]

Thanks for looking into this.
I primarily used this switch to disable collapsing of blocked network resources, e.g. images/frames so i still could use related js/link functionality.
For me personally the old behavior made sense,.
Maybe you could think of some replacement, or add option/flag to restore old behaviour?

[gorhill]

For future reference for myself, the code change occurred in 9c12ef0.

[gorhill]

Since a while now, I have been playing with the idea of providing "hidden" settings; settings which do not have a UI counterparts, but can be toggled on/off through the browser's specific UI (like about:config in FF). The idea is to not clutter the current UI with full of settings which are irrelevant for the majority of users.

Doing so would make it more easy for me to provide the kind of very specific behavior you want here. I think I will go ahead with this idea, as this will also allow me to also provide other customization settings which have been requested by a minority of users, but for which I do not want to provide a UI counterpart -- which would require more UI code, localization, documentation, etc. and drown the UI settings which are really relevant for the majority of users.

[kikaxa]

Sounds good, i think every project i coded for or used has some form of "advanced"/hidden settings.

[gorhill]

Closing, this would be far from trivial with no benefits for the wide majority of users justifying the development efforts, increased code complexity and risks of regression.