Skip to content

Commit

Permalink
Remove advanced setting ignoreScriptInjectFilters
Browse files Browse the repository at this point in the history
Ever since the `redirect` code was refactored:

157cef6

This advanced setting is no longer needed, as the same
can be accomplished with a plain network filter:

    @@*$redirect-rule
  • Loading branch information
gorhill committed Apr 13, 2021
1 parent d7c2e38 commit f5b453f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/js/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ const µBlock = (( ) => { // jshint ignore:line
extensionUpdateForceReload: false,
filterAuthorMode: false,
filterOnHeaders: false,
ignoreRedirectFilters: false,
ignoreScriptInjectFilters: false,
loggerPopupType: 'popup',
manualUpdateAssetFetchPeriod: 500,
Expand Down
1 change: 0 additions & 1 deletion src/js/pagestore.js
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,6 @@ const PageStore = class {
}

redirectBlockedRequest(fctxt) {
if ( µb.hiddenSettings.ignoreRedirectFilters === true ) { return; }
const directives = µb.staticNetFilteringEngine.redirectRequest(fctxt);
if ( directives === undefined ) { return; }
if ( µb.logger.enabled !== true ) { return; }
Expand Down

3 comments on commit f5b453f

@gorhill
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad commit message, I copy-pasted the wrong setting, I meant ignoreRedirectFilters, not ignoreScriptInjectFilters.

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoreScriptInjectFilters can also be accomplished with #@#+js()

@gorhill
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will remove this advanced setting as well. This also makes me realize I need to also mind this special exception form to avoid injecting the Permissions-Policy header.

Please sign in to comment.