Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

ABP rules blocking images can't be unblocked #330

Closed
ghost opened this issue Jun 6, 2014 · 5 comments
Closed

ABP rules blocking images can't be unblocked #330

ghost opened this issue Jun 6, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Jun 6, 2014

When I loaded this site:

http://www.faz.net/

a lot of images were blocked although the relevant subdomains media0.faz.net and media1.faz.net are whitelisted.

I finally found out that the culprit is the ABP Japanese Filters list where filters like

teaser_

teaser

are triggered. You may rightly ask why I've enabled that list ;-) . But my problem is: I've added the following exception rules to HTTPSB:

@@||media0.faz.net^
@@||media1.faz.net^

but the images are still blocked. Those exception filters should unblock those subdomains unless I'm completely misguided. Don't they take precedence over blocking rules in HTTPSB?

@gorhill
Copy link
Owner

gorhill commented Jun 6, 2014

Did you add the exception to the "Your block rules" or "Your allow rules"?

There is a mistake in the UI, ABP filter-like exceptions need to be added thtough the "Your block rules". I need to fix this.

@ghost
Copy link
Author

ghost commented Jun 6, 2014

Yes, you are right. That was the solution! Thanks a lot!

@gorhill gorhill closed this as completed in 0d332a4 Jun 6, 2014
@ghost
Copy link
Author

ghost commented Jun 8, 2014

Just to make sure that I understand the commit correctly: For "ubiquitousAllowFormatHint" you changed the description to "... or an Adblock Plus-compatible exception filter." Doesn't that contradict with what we agreed above? That exception rules have to be added to "your block rules"? I had added those exception rules - with and without prefixed @@ - to "Your allow rules" and they hadn't worked ...

@gorhill
Copy link
Owner

gorhill commented Jun 8, 2014

ABP exception filters can now be added in the "Your allow rules" as well. You were the second user who tried to add an exception filter in there so I had to support it in that field. Exception filters will still work in the "Your block rules" field. The @@ prefix has to be used regardless of which field the exception is entered -- this will ensure no confusion, @@ always means an exception filter.

I didn't release a version with the fix yet, so that will not work until I release a version. Or are you installing sources from the github branch?

@ghost
Copy link
Author

ghost commented Jun 8, 2014

Or are you installing sources from the github branch?

No, I'm not. I just stumpled upon it when I looked over my German translation. I had assumed that you would only adjust the description for both fields but not add the support in the second field.

The @@ prefix has to be used regardless of which field the exception is entered.

I suggest that we add this hint to the description. Otherwise users might think that this could be omitted if such rules are added to "Your allow rules".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant