Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

createPermanentGlobalScope() fails sometimes because if may leave one site or domain-level scope behind #163

Closed
gorhill opened this issue Jan 20, 2014 · 0 comments
Labels

Comments

@gorhill
Copy link
Owner

gorhill commented Jan 20, 2014

Because there is two flavors of site- or domain-level scope: http and https. Both flavors need to be removed when creating a broader scope. This is already taken care in the code.

Problem is in httpsb.js /createPermanentGlobalScope() :

    // Remove potentially occulting domain/site scopes.
    var scopeKey = this.siteScopeKeyFromURL(url);
    if ( this.removePermanentScopeFromScopeKey(scopeKey) ) {
        changed = true;
    }
    if ( scopeKey.indexOf('https:') === 0 ) {
        scopeKey = 'http:' + scopeKey.slice(6);
        if ( this.removeTemporaryScopeFromScopeKey(scopeKey) ) {
            changed = true;
        }
    }

removeTemporaryScopeFromScopeKey should be removePermanentScopeFromScopeKey.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant