Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#239] [Bug] The JWT token will be expired immediately when ttl == 0 #277

Merged
merged 3 commits into from
Aug 29, 2023
Merged

fix: [#239] [Bug] The JWT token will be expired immediately when ttl == 0 #277

merged 3 commits into from
Aug 29, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Aug 29, 2023 •
edited
Loading

Closes goravel/goravel#239

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% πŸŽ‰

Comparison is base (2b33966) 65.24% compared to head (8e00ded) 65.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   65.24%   65.30%   +0.05%     
==========================================
  Files         140      140              
  Lines        8785     8799      +14     
==========================================
+ Hits         5732     5746      +14     
  Misses       2648     2648              
  Partials      405      405
Files Changed Coverage Ξ”
auth/auth.go 85.71% <100.00%> (+1.36%) ⬆️

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@hwbrzzl hwbrzzl changed the title fix:[#239] [Bug] The JWT token will be expired immediately when ttl == 0 fix: [#239] [Bug] The JWT token will be expired immediately when ttl == 0 Aug 29, 2023
devhaozi
devhaozi approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 664976d into master Aug 29, 2023
10 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#239 branch August 29, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhaozi devhaozi devhaozi approved these changes

@kkumar-gcc kkumar-gcc Awaiting requested review from kkumar-gcc

Assignees
No one assigned
Labels
πŸš€ Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] The JWT token will be expired immediately when ttl == 0
2 participants
@hwbrzzl @devhaozi