Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource flag to make:controller #240

Merged

Conversation

mauri870
Copy link
Contributor

πŸ“‘ Description

This MR adds a --resource flag to the make controller command.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@mauri870 mauri870 changed the title wip: feat: add resource flag to make:controller feat: add resource flag to make:controller Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 85.82% and project coverage change: +0.28 πŸŽ‰

Comparison is base (989ae8b) 62.76% compared to head (296d136) 63.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   62.76%   63.04%   +0.28%     
==========================================
  Files         128      130       +2     
  Lines        8314     8378      +64     
==========================================
+ Hits         5218     5282      +64     
+ Misses       2735     2734       -1     
- Partials      361      362       +1     
Impacted Files Coverage Ξ”
auth/console/jwt_secret_command.go 0.00% <0.00%> (ΓΈ)
config/service_provider.go 0.00% <0.00%> (ΓΈ)
schedule/service_provider.go 0.00% <0.00%> (ΓΈ)
support/database/database.go 79.31% <0.00%> (ΓΈ)
http/console/controller_make_command.go 70.96% <42.85%> (-6.59%) ⬇️
contracts/foundation/service_provider.go 50.00% <50.00%> (ΓΈ)
foundation/application.go 62.50% <55.55%> (-0.61%) ⬇️
config/application.go 44.44% <100.00%> (-0.77%) ⬇️
console/console/key_generate_command.go 70.37% <100.00%> (ΓΈ)
http/console/stubs.go 100.00% <100.00%> (ΓΈ)
... and 3 more

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marian0
Copy link
Contributor

Marian0 commented Jul 14, 2023

Thanks @mauri870 πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants