Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Validation should ignore when a field is empty and is not required #188

Merged
merged 3 commits into from
Jun 17, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 17, 2023

πŸ“‘ Description

Validation should ignore when a field is empty and is not required

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (6c51c51) 62.02% compared to head (4b83bc8) 62.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   62.02%   62.00%   -0.03%     
==========================================
  Files         125      125              
  Lines        8051     8051              
==========================================
- Hits         4994     4992       -2     
- Misses       2729     2730       +1     
- Partials      328      329       +1     
Impacted Files Coverage Ξ”
validation/validator.go 60.60% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 5ee33e3 into master Jun 17, 2023
@hwbrzzl hwbrzzl deleted the bowen/optimize-validation branch June 17, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants