Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add make package command #162

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Feat: Add make package command #162

merged 2 commits into from
Jun 5, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 4, 2023 

go run . artisan make:package sms
image

@hwbrzzl hwbrzzl requested a review from devhaozi June 4, 2023 10:32
@hwbrzzl hwbrzzl changed the title Add make package command Feat: Add make package command Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 83.66% and project coverage change: +0.56 🎉

Comparison is base (7eaff3b) 52.46% compared to head (dd48e0e) 53.02%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   52.46%   53.02%   +0.56%     
==========================================
  Files         118      120       +2     
  Lines        8326     8479     +153     
==========================================
+ Hits         4368     4496     +128     
- Misses       3647     3670      +23     
- Partials      311      313       +2
Impacted Files Coverage Δ
foundation/application.go 62.76% <0.00%> (-0.68%) ⬇️
foundation/console/package_make_command.go 56.36% <56.36%> (ø)
foundation/console/package_make_command_stubs.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

devhaozi
devhaozi approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 359af8f into master Jun 5, 2023
@hwbrzzl hwbrzzl deleted the bowen/create-package-command branch June 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhaozi devhaozi devhaozi approved these changes

Assignees
No one assigned
Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwbrzzl @devhaozi