Feat: [#49] Support Package Development #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 52.10% 52.46% +0.35%
==========================================
Files 117 118 +1
Lines 8097 8326 +229
==========================================
+ Hits 4219 4368 +149
- Misses 3565 3647 +82
+ Partials 313 311 -2
☔ View full report in Codecov by Sentry. |
hwbrzzl
commented
Jun 3, 2023
There was a problem hiding this comment.
The master branch has an error now, the error is fixed in this PR and the PR needs the function in this file, so I optimized the console module here.
hwbrzzl
commented
Jun 3, 2023
Comment on lines
+44
to
+63
| &command.BoolFlag{ | ||
| Name: "existing", | ||
| Aliases: []string{"e"}, | ||
| Usage: "Publish and overwrite only the files that have already been published", | ||
| }, | ||
| &command.BoolFlag{ | ||
| Name: "force", | ||
| Aliases: []string{"f"}, | ||
| Usage: "Overwrite any existing files", | ||
| }, | ||
| &command.StringFlag{ | ||
| Name: "package", | ||
| Aliases: []string{"p"}, | ||
| Usage: "Package name to publish", | ||
| }, | ||
| &command.StringFlag{ | ||
| Name: "tag", | ||
| Aliases: []string{"t"}, | ||
| Usage: "One tag that have assets you want to publish", | ||
| }, |
There was a problem hiding this comment.
We can use different types of flags after optimizing the console module above.
hwbrzzl
commented
Jun 3, 2023
| return paths | ||
| } | ||
|
|
||
| func (receiver *VendorPublishCommand) packageDir(packageName string) (string, error) { |
There was a problem hiding this comment.
We can get the file content in a third package by go/build package, then we can publish the content to project.
devhaozi
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an example PR of how to build a third package: goravel/goravel#147
Close: goravel/goravel#49