[#120] Implement IoC Container #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 53.06% 52.26% -0.80%
==========================================
Files 105 117 +12
Lines 7570 8099 +529
==========================================
+ Hits 4017 4233 +216
- Misses 3268 3566 +298
- Partials 285 300 +15
☔ View full report in Codecov by Sentry. |
hwbrzzl
commented
May 6, 2023
facades/artisan.go
Outdated
| func NewArtisan() console.Artisan { | ||
| return App().MakeArtisan() | ||
| } |
There was a problem hiding this comment.
Temporarily add NewArtisan, will replace Artisan: func NewArtisan() console.Artisan
hwbrzzl
commented
May 6, 2023
facades/config.go
Outdated
Comment on lines
7
to
9
| var Config = NewConfig() | ||
|
|
||
| func NewConfig() configcontract.Config { | ||
| return App().MakeConfig() | ||
| } |
There was a problem hiding this comment.
Temporarily add NewArtisan, will replace Config: func Config() configcontract.Config
1 task
devhaozi
previously approved these changes
May 13, 2023
hwbrzzl
commented
May 20, 2023
| "github.com/goravel/framework/contracts/http" | ||
| "github.com/goravel/framework/facades" |
There was a problem hiding this comment.
All of the modules shouldn't be dependent on facades and should inject if needed.
hwbrzzl
commented
May 20, 2023
| } | ||
|
|
||
| func (s *AuthTestSuite) TestLoginUsingID_EmptySecret() { | ||
| mockConfig := mock.Config() |
There was a problem hiding this comment.
All of the test cases shouldn't be dependent on the github.com/goravel/framework/testing/mock package, will cause import cycle error, use &cachemock.Cache{} instead.
hwbrzzl
commented
May 20, 2023
Comment on lines
+19
to
+26
| app.Singleton(BindingAuth, func() (any, error) { | ||
| config := app.MakeConfig() | ||
| return NewAuth(config.GetString("auth.defaults.guard"), | ||
| app.MakeCache(), config, app.MakeOrm()), nil | ||
| }) | ||
| app.Singleton(BindingGate, func() (any, error) { | ||
| return access.NewGate(context.Background()), nil | ||
| }) |
There was a problem hiding this comment.
Bind and inject like this.
hwbrzzl
commented
May 20, 2023
database/gorm/wire.go
Outdated
There was a problem hiding this comment.
Use wire to implement dependency injection.
hwbrzzl
added a commit
that referenced
this pull request
May 26, 2023
* Optimize service container * Adaptation Crypt module * Adaptation Cache module * Adaptation contracts * Adaptation Event module * Adaptation Foundation module * Adaptation Queue module * Adaptation DB module * Adaptation filesystem module * Adaptation filesystem module * Adaptation facades module * Adaptation Auth module * Adaptation Http module * Adaptation Grpc module * Adaptation Log module * Adaptation Mail module * Adaptation Route module * Adaptation Schedule module * Adaptation Filesystem module * Adaptation other module * Adaptation Hash module * Fix unit tests * Optimize code * Add unit tests * Rebase * Optimize unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: goravel/goravel#120