Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ipv6 #47

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat: support ipv6 #47

merged 1 commit into from
Dec 13, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Dec 13, 2023

Closes goravel/goravel#308

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@devhaozi devhaozi requested a review from a team December 13, 2023 10:24
@devhaozi devhaozi self-assigned this Dec 13, 2023
@devhaozi devhaozi enabled auto-merge (squash) December 13, 2023 10:24
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (53e542d) 78.46% compared to head (0f1bc2d) 78.17%.

Files Patch % Lines
route.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   78.46%   78.17%   -0.30%     
==========================================
  Files          10       10              
  Lines         873      875       +2     
==========================================
- Hits          685      684       -1     
- Misses        161      163       +2     
- Partials       27       28       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@devhaozi devhaozi merged commit 2507f00 into master Dec 13, 2023
@devhaozi devhaozi deleted the haozi/ipv6 branch December 13, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] IPV6 support
3 participants