feat: [#504] Route supports configure timeout #112

KlassnayaAfrodita · 2024-10-09T15:57:41Z

github.com/goravel/goravel/issues/504

add WithContext

📑 Description

Closes goravel/goravel#504

@coderabbitai summary

✅ Checks

Added test cases for my code

github.com/goravel/goravel/issues/504 add WithContext

hwbrzzl

Please merge your two PRs, one PR is fine. And add the global configuration logic.

goravel#112

KlassnayaAfrodita · 2024-10-10T15:30:00Z

i merged two PRs

coderabbitai · 2024-10-28T01:12:15Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hwbrzzl

Please update this PR according to the gin PR.

hwbrzzl

Sorry, there are a lot of issues, please follow the goravel/gin PR to update this.

Update go.mod, upgrade goravel/framework to the latest version;
Remove the test case in context_test.go, just like what goravel/gin did;
Update route.go::GlobalMiddleware, just like what goravel/gin did;
Update group_test.go, the test cases should not pass now;
Rename cors.go to middleware_cors.go, the same as tls.go;
Bebase your branch;

hwbrzzl · 2024-10-31T07:01:53Z

Thanks for your updates. I'm not sure if this PR is ready to be reviewed again, just notice, a few points are still not updated. eg: go.mod, rename file, etc.

The merge-base changed after approval.

hwbrzzl · 2024-11-06T02:17:56Z

Unfortunately, CI still failed.

hwbrzzl · 2024-11-06T02:18:36Z

You can ask me if you have any questions for this.

KlassnayaAfrodita · 2024-11-06T13:57:37Z

You can ask me if you have any questions for this .

Do I understand correctly that I need to update the mock files?

hwbrzzl · 2024-11-06T15:05:01Z

You can ask me if you have any questions for this .

Do I understand correctly that I need to update the mock files?

No, unit tests failed, did you run unit tests locally?

KlassnayaAfrodita · 2024-11-06T21:13:59Z

You can ask me if you have any questions for this .

Do I understand correctly that I need to update the mock files?

No, unit tests failed, did you run unit tests locally?

I get about the same thing

hwbrzzl · 2024-11-07T01:34:18Z

Yes, you need to optimize the test flow, there are some unexpected mockConfig assertion.

hwbrzzl · 2024-11-09T07:04:55Z

Hey @KlassnayaAfrodita Are you still working on this, please? If you feel it's difficult to fix the CI, you can add me to your fiber repo, I can solve it.

KlassnayaAfrodita · 2024-11-10T19:07:13Z

I invited you to the repository, could you then describe how this problem is solved. current branch patch-1

codecov-commenter · 2024-11-11T09:47:44Z

Codecov Report

Attention: Patch coverage is 68.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 76.05%. Comparing base (80773b6) to head (fa4f915).
Report is 38 commits behind head on master.

Files with missing lines	Patch %	Lines
response.go	17.24%	16 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   79.09%   76.05%   -3.04%     
==========================================
  Files          10       13       +3     
  Lines         885     1040     +155     
==========================================
+ Hits          700      791      +91     
- Misses        159      214      +55     
- Partials       26       35       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update context.go

3879526

github.com/goravel/goravel/issues/504 add WithContext

KlassnayaAfrodita requested a review from a team as a code owner October 9, 2024 15:57

hwbrzzl reviewed Oct 10, 2024

View reviewed changes

Update context_test.go

4d84d8a

goravel#112

KlassnayaAfrodita added 4 commits October 21, 2024 00:36

Update route.go

643374b

Create timeout_middleware.go

fb1cae5

Update route_test.go

d841b14

Merge branch 'master' into patch-1

d6f9be9

hwbrzzl reviewed Oct 28, 2024

View reviewed changes

KlassnayaAfrodita added 4 commits October 28, 2024 19:16

Update timeout_middleware.go

b57f778

Create timeout_middleware_test.go

7a50c35

Update route.go

6548895

Update route.go

6a1323c

KlassnayaAfrodita changed the title ~~Update context.go~~ feat: [#504] Route supports configure timeout Oct 28, 2024

KlassnayaAfrodita added 2 commits October 29, 2024 23:10

Update go.mod

1487e59

Update go.sum

af292b1

hwbrzzl reviewed Oct 30, 2024

View reviewed changes

KlassnayaAfrodita added 9 commits October 30, 2024 14:52

Update context_test.go

7f6d9cc

Update route.go

cc7cf92

Update timeout_middleware.go

636d33d

Update route.go

7871161

Update group_test.go

3fec5ea

Rename cors.go to cors_middleware.go

a4322af

Update and rename cors_test.go to cors_middleware_test.go

42ebeb4

Update context_response_test.go

6892540

Update context_response_test.go

4866f20

Update go.mod

072d8c8

KlassnayaAfrodita added 4 commits November 4, 2024 18:36

Update context_test.go

aa67f21

Update route_test.go

753bfff

Update go.mod

e33bb02

Update go.sum

45221bf

coderabbitai bot previously approved these changes Nov 5, 2024

View reviewed changes

Merge branch 'master' into patch-1

d33b4d4

KlassnayaAfrodita added 6 commits November 5, 2024 16:28

Update group_test.go

e6c7b36

Update middleware_timeout.go

a066b9b

Update middleware_timeout_test.go

ac7691e

Update context.go

0be8e51

Update route.go

cce3829

Update utils.go

b6cb81e

hwbrzzl added 6 commits November 11, 2024 14:32

fix unit tests

eab1c99

fix unit tests

a0f02c7

fix unit tests

51cf6da

add comment

9020aa4

Merge branch 'master' into patch-1

d9e6320

fix unit tests

fa4f915

hwbrzzl approved these changes Nov 11, 2024

View reviewed changes

hwbrzzl merged commit 36c678c into goravel:master Nov 11, 2024
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [#504] Route supports configure timeout #112

feat: [#504] Route supports configure timeout #112

KlassnayaAfrodita commented Oct 9, 2024

hwbrzzl left a comment

KlassnayaAfrodita commented Oct 10, 2024

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

hwbrzzl left a comment

hwbrzzl left a comment •

edited

Loading

hwbrzzl commented Oct 31, 2024 •

edited

Loading

hwbrzzl commented Nov 6, 2024

hwbrzzl commented Nov 6, 2024

KlassnayaAfrodita commented Nov 6, 2024 •

edited

Loading

hwbrzzl commented Nov 6, 2024

KlassnayaAfrodita commented Nov 6, 2024

hwbrzzl commented Nov 7, 2024

hwbrzzl commented Nov 9, 2024

KlassnayaAfrodita commented Nov 10, 2024

codecov-commenter commented Nov 11, 2024

feat: [#504] Route supports configure timeout #112

feat: [#504] Route supports configure timeout #112

Conversation

KlassnayaAfrodita commented Oct 9, 2024

📑 Description

✅ Checks

hwbrzzl left a comment

Choose a reason for hiding this comment

KlassnayaAfrodita commented Oct 10, 2024

coderabbitai bot commented Oct 28, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl left a comment • edited Loading

Choose a reason for hiding this comment

hwbrzzl commented Oct 31, 2024 • edited Loading

hwbrzzl commented Nov 6, 2024

hwbrzzl commented Nov 6, 2024

KlassnayaAfrodita commented Nov 6, 2024 • edited Loading

hwbrzzl commented Nov 6, 2024

KlassnayaAfrodita commented Nov 6, 2024

hwbrzzl commented Nov 7, 2024

hwbrzzl commented Nov 9, 2024

KlassnayaAfrodita commented Nov 10, 2024

codecov-commenter commented Nov 11, 2024

Codecov Report

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

hwbrzzl left a comment •

edited

Loading

hwbrzzl commented Oct 31, 2024 •

edited

Loading

KlassnayaAfrodita commented Nov 6, 2024 •

edited

Loading