You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It means that if I want to ignore .tmp files and if I rename a file from test.txt to test.tmp, then the event handler will still take into account that change. That is because we filter on all paths and if one is not ignored, then it considers the event as a one.
I think, if I understand correctly, the this is not the desired behavior.
On the other hand, if we check the dispatch method of RegexMatchingEventHandler:
I was trying to ignore several patterns using the
PatternMatchingEventHandler
class. In thedispatch
method, we have that behavior:It means that if I want to ignore
.tmp
files and if I rename a file fromtest.txt
totest.tmp
, then the event handler will still take into account that change. That is because we filter on all paths and if one is not ignored, then it considers the event as a one.I think, if I understand correctly, the this is not the desired behavior.
On the other hand, if we check the
dispatch
method ofRegexMatchingEventHandler
:Clearly, here, if one of the paths is ignored, then we stop now. That is the wanted behavior.
So, should I send a PR to fix
PatternMatchingEventHandler
behavior? Perhaps I misunderstand how to use that class or its purpose, let me know.The text was updated successfully, but these errors were encountered: