Add json tags to clientconfig's structs #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some yaml libraries use json tags to drive serialization for both, json and yaml. This patch adds json tags to the clientconfig's structs to support those libraries. The lack of these tags has caused some integration issues with other softare using packages like `ghodss/yaml`. An example of this can be found in the PR linked below: openshift/installer#854
flaper87
added a commit
to flaper87/installer
that referenced
this pull request
Feb 13, 2019
json tags were added to clientconfig. we shouldn't need yaml.v2 anymore: gophercloud/utils#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some yaml libraries use json tags to drive serialization for both, json
and yaml. This patch adds json tags to the clientconfig's structs to
support those libraries.
The lack of these tags has caused some integration issues with other
softare using packages like
ghodss/yaml. An example of this can befound in the PR linked below:
openshift/installer#854