AuthenticatedClient doesn't respect the ClientOpts.HTTPClient setting

[kayrus]

utils/openstack/clientconfig/requests.go

Line 730 in de873b9

ao, err := AuthOptions(opts)

call just ignores the HTTPClient member.

[pierreprinetti]

Hi @kayrus, thanks for reporting.

The gophercloud.AuthOptions object that func AuthOptions returns does not contain any HTTPClient, and apparently AuthOptions itself doesn't do any HTTP call. I believe that the HTTPClient contained in ClientOpts is intended for use in func NewServiceClient.

Please provide a minimal reproducer, and be specific about the behaviour you expected, so that I can better understand if we're missing something in code or in the docs.

[kayrus]

See a linked issue. I think velero plugin author expected that providing ClientOpts.HTTPClient inherits it for the resulting provider client, but apparently it doesn't. I think it's a confusion, which can be fixed in utils.

[pierreprinetti]

OK, understood. Please feel free to propose a solution in words or in code; I'll be happy to review.
If instead you'd like me to investigate the issue, I'll need a minimal reproducer.