add tvOS structures to export_unity_package.py #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkuang-g
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Could you update the following things:
export_unity_package.py- Line 75. Please update the comment and addtvOSto it.
https://github.com/googlesamples/unity-jar-resolver/blob/master/source/ExportUnityPackage/export_unity_package.py#L75- Add a test for tvOS here as well. You should be able to run this test using
./gradlew testExportUnityPackage
https://github.com/googlesamples/unity-jar-resolver/blob/master/source/ExportUnityPackage/export_unity_package_test.py#L2045
chkuang-g
requested changes
Sep 26, 2022
|
Updated. Please take a look! |
chkuang-g
approved these changes
Sep 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
export_unity_package.pywith the ability to handletvOSbuild targets.