-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Release HERE!!!] Update native sdk version to 6.0.2 & REFECTOR iOS Adapter #205
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS and works great! Many thanks
Would you fire a new release? |
I don't work for Google, can I do that?
…On Thu, Oct 27, 2022 at 12:29 AM Spermoverflow ***@***.***> wrote:
Tested on iOS and works great! Many thanks
Would you fire a new release?
—
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIT6YXYJDKFRSKV6DKDP3WFIVMPANCNFSM5KFHXUMA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Roger Miller | Collective Mass | 424 603 7827
|
Aha. I mistakenly thought you work for Google~ |
This could help me and my guys but I have a hard time to build this, I am not much in Java anymore since C# exists, can anyone tell me what to do to build this? I tried on Windows WSL 2 and got the below error.
thanks for any help Edit1: After following this guide https://www.javaprogramto.com/2021/11/could-not-determine-java-version.html
gradle version is at 5.4.1 About that sdk issues there is an addon to the readme in this fork https://github.com/wakawa2003/google-signin-unity-fixed |
So sorry for the inconvenience.
If it works, it would be nice to let me know. @karstenkx |
Yes, in the end It worked when I installed that stone old "latest" release and then use the files in your PR , put them into the project overwritting , we both know a proper build and package release would be better |
@karstenkx |
Having the same issue as @MrKhan2022. I'm pretty sure it was working a few days ago. Any help would be appreciated. Edit: If anyone still struggling with this, changing the dependency version from >=6.0.2 to =6.2.4 solved it for me. |
@Crazak Glad to hear that you have work around the issue. Edit: May I have your unity version and xcode version(with macos version)? |
Unity Version: 2021.3.8f1 |
Guys please help me, still getting error like @MrKhan2022 described |
I cant find |
GoogleSignIn@JokeMaker.unitypackage.zip |
Hi, I'm trying to build this, but I'm having a similar error to MrKhan, but in my case is another file (GIDSignIn), I've tried creating a new project and importing everything cited on this thread, but it still happens, even switch from 6.0.2 to 6.2.4. |
hi, @matbn |
@CodeMasterYi yes, and I've also tried with a fresh project too, just importing the plugin-1.0.4, your files and the sample scene |
hi @matbn one more thing, it depends this plugin https://github.com/googlesamples/unity-jar-resolver/releases/tag/v1.2.175 |
@CodeMasterYi using only your package with the jar resolver I could build, thank you for the help and for the updates. |
@matbn Glad to hear that. |
@way2tushar In my case I've only changed this path: |
@ingames Hi I am still stuck on this can you please explain bit more Firebase version 10.11.0 My Pod FIles |
@devendraatxpertaapp |
@way2tushar @ingames |
OK. So it seem this repo is not maintain anymore? Even the fix pull request are not being merged for nearly 2 years |
Maybe they forget it or build another new one. |
We need a hero 🦸🏻♂️ |
Using this package GoogleSignIn@JokeMaker.unitypackage.zip and changing ~> 6.0.2 to 6.2.4 on dependency file works for me!!
|
Recently, there was 7.0.0 version of GoogleSign-iOS. So I modified Dependecies (iosPods target version to > 6.0.2) Then, I found some functions are deleted, changed and GIDAuthentication header has been moved to private Here's a modified package with googlesignin.mm file |
@DulgiKim Thank you very much my friend. I have been trying to solve this issue past 10 hours straight. I wish i had seen your comment earlier. You are such a god send fellow. Thanks a lot. |
I have patch this repo into UPM system https://github.com/Thaina/google-signin-unity You can added this link https://github.com/Thaina/google-signin-unity.git with UPM UI Please let me know are there any problem from my package |
@Thaina
|
Hmm that's weird. For me it's opposite. I need to add firebase core package Could you make very simple project that fail so I can take a look (but I don't have access to macos machine until next week though) |
Does anybody else have google signin crash immediately on ios with no error message on PInvokeFunc(GoogleSignIn_SignIn) in GoogleAuth? |
yes! 6.0.2 to 6.2.4 wroked!!!nice |
Can any one know how to import this package in unity project because everytime I am importing it is giving error in unity "Unable to import the package." |
Unzip this zip file first, and you will get an file that ends with '.unitypackage'. import it. |
UPDATE: I am using the latest firebase sdk + googlesingin plugin from the comment below. The code compiles, I have added debug code to the .mm file to check if the info list is loaded Attempting to log in with Google but still it's not working, will update if it works soon
|
Okay Few weeks later, still struggling with this. I got this error with unity 2023.2.5f1 I got firebase sdk9.6 to work on IOS with the fix (see in my previous comment above) but then the android didn't work with 9.6 so I updated to Firebase sdk 11.6 and the android works after resolving some issues with additional androids libraries included by the resolver. but then the code doesn't work on iOS. I managed to get it to compile but now I have a crash. to compile I did three changes, not sure which one solved it:
Now the error I'm getting is: Attempting to log in with Google Google Sign-In configured. *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'No active configuration. Make sure GIDClientID is set in Info.plist.' |
Firebase SDK 11.0 + IOS now works Fixed the error by adding the GID + URL schemes required by Googleiosignin 7.0.0. Created the following build script and placed it in Assets/Editor to make sure it runs on build #if UNITY_IOS public class PostBuildProcessor
} |
Greeting Everyong My fork of this package that enabled UPM has new branch. Now it was upgraded to use the latest version of signin library for ios and CredentialManager for android because google signin for both platform has recommendation for migration https://developer.android.com/identity/sign-in/legacy-gsi-migration Here is my forked repo https://github.com/Thaina/google-signin-unity/tree/newmigration You can compare the changes here #256 Or just add these 2 lines to your manifest.json project to import this package into your project {
"dependencies": {
"com.google.external-dependency-manager": "https://github.com/googlesamples/unity-jar-resolver.git?path=upm",
"com.google.signin": "https://github.com/Thaina/google-signin-unity.git#newmigration",
...
}
} external-dependency-manager is required dependency, if it already in your project then you can just omit that line |
I can confirm that after using this package https://github.com/CodeMasterYi/google-signin-unity/releases and changing the line in the GoogleSignInDependencies.xml as below worked for me. Thank you so much
|
Thank you! GoogleSignIn 7.0.0 and your modified package worked with Firebase 10.15.0 |
I don't know if this is the best solution, but it worked. Deleting |
Need help. How i can do import GoogleSignIn.zip ? |
Update native sdk version to latest & refactor iOS adapter!
before google's future new release(greater than 1.0.4 released in 2018), you guys can
try import this. GoogleSignIn@JokeMaker.unitypackage.zip
It depends on EDM4U(aka. unity-jar-resolver).
https://github.com/CodeMasterYi/google-signin-unity/releases